Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration for captured mime types. #183

Merged
merged 7 commits into from
Jan 24, 2022

Conversation

tpapp
Copy link
Contributor

@tpapp tpapp commented Jan 17, 2022

Fixes #182.

@fredrikekre
Copy link
Owner

Which markdown parser/renderer are you using that can handle svgs embedded like this? Maybe it is standard, but I don't think Documenter handles it for example?

@tpapp
Copy link
Contributor Author

tpapp commented Jan 19, 2022

Sorry I don't understand the question, svgs generated by this PR are not embedded but end up as links ![](somefile.svg).

@fredrikekre
Copy link
Owner

Yea, thats what I meant. Does that work in e.g. Documenter?

@tpapp
Copy link
Contributor Author

tpapp commented Jan 20, 2022

It works with Franklin, which is my intended use case. See screenshot.

lit

@fredrikekre
Copy link
Owner

Maybe it can be default then for the Franklin-flavor?

@tpapp
Copy link
Contributor Author

tpapp commented Jan 23, 2022

I think it works with Documenter.jl too (screenshot below).

Unless there is a case where it does not work (but the other formats do), I would just make it a default for all flavors.

screenshot

@fredrikekre
Copy link
Owner

Yea, lets do that.

@tpapp
Copy link
Contributor Author

tpapp commented Jan 24, 2022

Done. If you merge this, can you please make a release?

src/Literate.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
test/runtests.jl Outdated Show resolved Hide resolved
tpapp and others added 3 commits January 24, 2022 14:14
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
Co-authored-by: Fredrik Ekre <ekrefredrik@gmail.com>
src/Literate.jl Outdated Show resolved Hide resolved
@fredrikekre fredrikekre merged commit cb788bc into fredrikekre:master Jan 24, 2022
@fredrikekre
Copy link
Owner

Thanks.

@tpapp tpapp deleted the tp/customize-image-formats branch January 24, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

embed svg instead of png for plot
2 participants